Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc: do not check sizes in not loadable sections #590

Merged
merged 1 commit into from
Oct 2, 2024
Merged

proc: do not check sizes in not loadable sections #590

merged 1 commit into from
Oct 2, 2024

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Sep 10, 2024 •
edited
Loading

JIRA: RTOS-912

Description

memsz doesn't matter in that case, caused bug if there was a section with arch data

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: riscv-generic-qemu

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   37m 10s ⏱️ -7s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit f78a283. ± Comparison against base commit 1f9ea40.

♻️ This comment has been updated with latest results.

@badochov badochov mentioned this pull request Sep 11, 2024
Closed
14 tasks
@badochov badochov mentioned this pull request Sep 24, 2024
Open
14 tasks
@badochov badochov merged commit cb7fddd into master Oct 2, 2024
30 checks passed
@badochov badochov deleted the badochov/elf-validate branch October 2, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darchiv Darchiv Darchiv approved these changes

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badochov @Darchiv @agkaminski